![]() ![]() Contributor License Agreement can be verified by Googlers at.Ensure the new entry is reviewed by a reviewer who works for Google. ![]() If the author or their company is not listed, the CL should include a new AUTHORS entry. In some cases, the author's company might have a wildcard rule (e.g. Ensure the author is already listed in AUTHORS.Definition: The “author” is the email address that owns the code review request on.External contributor checklist for reviewersīefore LGTMing a change from a address, ensure that the contribution can be accepted: Please include this as part of your first patch and not as a separate standalone patch. First-time contributorsĪdd your (or your organization's) name and contact info to the AUTHORS file for Chromium or Chromium OS. Corporate contributors must fill out the Corporate Contributor License Agreement and send it to us as described on that page. Legal stuffĪll contributors must have valid Gerrit/Google accounts (which means you must be old enough to manage your own account) and complete the contributor license agreement.įor individual contributors, please complete the Individual Contributor License Agreement online. Send public design docs to Google internal Chrome design docs should follow the process at go/chrome-dd-review-process. When beginning a large technical undertaking that should be documented for historical reasons (>1 person-month of work can be used as a general guideline).when you are changing code in Chromium's critical path (page loading, rendering). When writing code that will have a large impact on Chromium as a whole, e.g.Specifically, we require design docs in the following cases: Just because there is a bug in the bug system doesn't necessarily mean that a patch will be accepted.Īny nontrivial technical effort that will significantly impact Chromium should have a design doc ( template).If there isn't a bug and there should be one, please file a new bug.Bugs are unnecessary for changes isolated enough to need none of these. Bugs are the right place for long histories, discussion and debate, attaching screenshots, and linking to other associated bugs. If a change needs further context outside the CL, it should be tracked in the bug system.If it’s in the existing code base, talk to some of the folks in the “OWNERS” file (see code review policies for more) for the code being changed. If it‘s a new feature idea, propose it to the appropriate discussion group. When writing a new feature or fixing an existing bug, get a second opinion before going too far. Tutorial by committer emeritus Commit Checklist, a useful checklist to go through before submitting each CL on Gerrit.Life of a Chromium Developer, which is mostly up-to-date.External contributor checklist for reviewers. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |